fix(suggestions) make initial suggestions clickable #489
+40
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
The initial/hardcoded suggestions were not being added to the input
field on click. This was because the
disableAutoSuggest()
function,which is called when the keyboard is in an idle state, was explicitly
setting the
onClickListener
for the suggestion buttons to null.This commit attaches a new
OnClickListener
to each defaultsuggestion button. The listener's logic commits the button's text
to the current input connection, mirroring the behavior of the dynamic,
next-word suggestions.
Closes #487