Skip to content

Conversation

catreedle
Copy link
Collaborator

Contributor checklist


Description

This PR is adding info text for when a vocabulary is not found on Wikidata, and also showing a clear description about it

Copy link

github-actions bot commented Sep 1, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Sep 1, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@catreedle
Copy link
Collaborator Author

hi @angrezichatterbox @andrewtavis

looking forward to your reviews on this. I tried to separate the invalid keyboard into its own xml file, but I struggled to do that.
I also don't know how to trigger the invalid state on conjugation, so there's a bit of mix-up between the invalid state and the conjugate state, would love some help with that 😅
Thank you

@andrewtavis
Copy link
Member

Thanks so much for the PR, @catreedle! We'll try to get to a review soon :) :)

@angrezichatterbox
Copy link
Member

I will look into the code later tmrw. Functionality wise everything looks fine until now. Could you share the exact mixup that you are mentioning so I could look into that while reviewing.

We would have to include a check for making sure that Data not available is shown for conjugate as well. I would create an issue for that soon.

@catreedle
Copy link
Collaborator Author

Hi, @angrezichatterbox
Thank you. I'm looking forward to the review.

This is the mix-up I'm talking about. Sometimes the keyboard gets stuck in a conjugate state.

conjugate_plural.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants