-
Notifications
You must be signed in to change notification settings - Fork 83
Invalid info #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Invalid info #482
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
hi @angrezichatterbox @andrewtavis looking forward to your reviews on this. I tried to separate the invalid keyboard into its own xml file, but I struggled to do that. |
Thanks so much for the PR, @catreedle! We'll try to get to a review soon :) :) |
I will look into the code later tmrw. Functionality wise everything looks fine until now. Could you share the exact mixup that you are mentioning so I could look into that while reviewing. We would have to include a check for making sure that Data not available is shown for conjugate as well. I would create an issue for that soon. |
Hi, @angrezichatterbox This is the mix-up I'm talking about. Sometimes the keyboard gets stuck in a conjugate state. conjugate_plural.webm |
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
This PR is adding info text for when a vocabulary is not found on Wikidata, and also showing a clear description about it