Skip to content

Conversation

Wreck-X
Copy link
Contributor

@Wreck-X Wreck-X commented Aug 13, 2025

Contributor checklist


Description

This update checks for punctuation when normal space is pressed to ensure that the next key is capitalised

Related issue

Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Aug 13, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks so much for the PR, @Wreck-X! 😊 We'll try to get to the review in the coming days :)

@angrezichatterbox
Copy link
Member

I assume this is supposed to work like If we type a few letters and then the space the keyboard would be capitalized right.
I am currently not able to do that.

@Wreck-X
Copy link
Contributor Author

Wreck-X commented Aug 20, 2025

Punctuation -> space -> then capitalisation
It is supposed to not work with only space,
Would result in every word being capitalised if that's the case

@angrezichatterbox
Copy link
Member

This is what I did

  1. I typed some text.
  2. Put a full stop
  3. Then entered a space.

After this the keyboard is supposed to be capitalized right.

@Wreck-X
Copy link
Contributor Author

Wreck-X commented Aug 22, 2025

It is yes, lemme check myself I might've missed a few commits

@Wreck-X Wreck-X force-pushed the period-after-space branch from eee2b46 to 1670dd2 Compare August 24, 2025 09:18
@andrewtavis
Copy link
Member

Would you be able to look into the Ktlint and Detekt errors, @Wreck-X? :)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the PR. @Wreck-X ! It really improves the user experience.

Looking forward to working with you again :)

@angrezichatterbox angrezichatterbox linked an issue Sep 13, 2025 that may be closed by this pull request
2 tasks
@angrezichatterbox angrezichatterbox merged commit d3b6f51 into scribe-org:main Sep 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-capitalization after a full stop
3 participants