-
Notifications
You must be signed in to change notification settings - Fork 85
Auto capitalisation after punctuation. #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto capitalisation after punctuation. #474
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
Thanks so much for the PR, @Wreck-X! 😊 We'll try to get to the review in the coming days :) |
I assume this is supposed to work like If we type a few letters and then the space the keyboard would be capitalized right. |
Punctuation -> space -> then capitalisation |
This is what I did
After this the keyboard is supposed to be capitalized right. |
It is yes, lemme check myself I might've missed a few commits |
eee2b46
to
1670dd2
Compare
Would you be able to look into the Ktlint and Detekt errors, @Wreck-X? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the PR. @Wreck-X ! It really improves the user experience.
Looking forward to working with you again :)
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
This update checks for punctuation when normal space is pressed to ensure that the next key is capitalised
Related issue