-
Notifications
You must be signed in to change notification settings - Fork 79
Implement Conjugate for Swedish and Russian #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement Conjugate for Swedish and Russian #438
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
a337673
to
5aa327e
Compare
I have made the changes. It is ready for review. |
A couple of quick comments here, @angrezichatterbox :)
![]() I think we should be good after these changes come in! |
I will add these changes in a while. |
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
This PR adds conjugate support for Swedish and Russian language and fixes the bugs present in the German conjugate mode that caused it to not produce the right output for Perfect tenses.
Related issue