Skip to content

Implement Conjugate for Swedish and Russian #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

This PR adds conjugate support for Swedish and Russian language and fixes the bugs present in the German conjugate mode that caused it to not produce the right output for Perfect tenses.

Related issue

Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Jul 20, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox angrezichatterbox force-pushed the feat/conjugate-for-swedish-russian branch from a337673 to 5aa327e Compare July 20, 2025 09:21
@angrezichatterbox
Copy link
Member Author

I have made the changes. It is ready for review.

@andrewtavis
Copy link
Member

A couple of quick comments here, @angrezichatterbox :)

  • The verb isn't being read in for Swedish if it's capitalized
  • We have a slight overflow of the label of the bottom right 2x2 cell (see screenshot below)
Screenshot_20250724_224705

I think we should be good after these changes come in!

@angrezichatterbox
Copy link
Member Author

I will add these changes in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants