-
Notifications
You must be signed in to change notification settings - Fork 905
[UEPR-429] Remove "Set Thumbnail" feature callout #9953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UEPR-429] Remove "Set Thumbnail" feature callout #9953
Conversation
KManolov3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd also want to remove the logic related to the modal shown after the tooltip closes. See https://github.com/scratchfoundation/scratch-www/pull/9638/files for reference on the PR that introduced the feature callout.
ah yes my bad |
…github.com:kbangelov/scratch-www into task/uepr-429-remove-set-thumbnail-feature-callout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the "Set Thumbnail" feature callout by eliminating the tooltip and modal that introduced users to the thumbnail update functionality.
- Removes tooltip popup logic and state management for the thumbnail update feature
- Deletes the UpdateThumbnailInfoModal component and associated styles
- Removes localization strings for the tooltip and modal
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/preview/project-view.scss | Removes tooltip-specific styles including overlay hiding and popover styling |
| src/views/preview/project-view.jsx | Removes tooltip/modal state, lifecycle methods, and related function parameters |
| src/views/preview/l10n.json | Removes localization strings for tooltip and modal text |
| src/components/modal/update-thumbnail-info/modal.scss | Deletes entire stylesheet for the modal component |
| src/components/modal/update-thumbnail-info/modal.jsx | Deletes entire modal component file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KManolov3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Resolves:
https://scratchfoundation.atlassian.net/browse/UEPR-429
Changes:
Deletes the tooltip popup logic and all code related to it in the project view page component