Skip to content

Conversation

@kbangelov
Copy link
Contributor

Resolves:

https://scratchfoundation.atlassian.net/browse/UEPR-427

Changes:

Replaces all /terms_of_use with new link
all /privacy_policy with new link

Question:

Not clear to me whether those pages should be deleted since there should be no links leading to them left over. To be clarified.

},
{
"name": "privacypolicy-apps",
"pattern": "^/privacy_policy/apps?$",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this should be deleted as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change the routes

@kbangelov kbangelov force-pushed the bugfix/uepr-427-wrong-tou-and-privacy-policy-links branch from 84c554c to 5577553 Compare December 5, 2025 14:07
@kbangelov kbangelov changed the base branch from release/terms-of-use to develop December 5, 2025 14:09
time. You can always find the latest version of the Terms of Use
at <a href="/terms_of_use">http://scratch.mit.edu/terms_of_use</a>.
at <a href="https://mitscratch.freshdesk.com/en/support/solutions/articles/4000219182-scratch-terms-of-use">
https://mitscratch.freshdesk.com/en/support/solutions/articles/4000219182-scratch-terms-of-use</a>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure if a link this long should appear in a text. Perhaps it should just say "Terms of Use"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's a good question. I think it's better if the text stays as it was for now, but still refers to the freshdesk link. In any case, this page shouldn't be accessible through the regular flow (and will only be accessible via url).

@cwillisf what do you think?

@kbangelov kbangelov force-pushed the bugfix/uepr-427-wrong-tou-and-privacy-policy-links branch from 5577553 to 66ceab8 Compare December 5, 2025 14:25
@kbangelov kbangelov changed the base branch from develop to release/terms-of-use December 5, 2025 14:25
@rosics-code
Copy link

#9915

What about this? @kbangelov

@kbangelov
Copy link
Contributor Author

#9915

What about this? @kbangelov

I don't fully comprehend the conflict of "Check for other places in the code, where Terms of Use or Privacy Policy leads to the internal page instead of Freshdesk and update them" and that PR which updates them, considering we want to replace all the links for the internal ToU page.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Terms of Use and Privacy Policy links throughout the codebase to point to new Freshdesk URLs instead of internal routes. The changes also remove the corresponding route definitions since these pages are now hosted externally.

Key Changes:

  • Replaced all /terms_of_use references with the new Freshdesk Terms of Use URL
  • Replaced all /privacy_policy references with the new Freshdesk Privacy Policy URL
  • Removed internal route definitions for these pages from routes.json

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/views/terms/terms.jsx Updated Privacy Policy and Terms of Use links to external Freshdesk URLs
src/views/teachers/faq/faq.jsx Updated Privacy Policy links in teacher FAQ
src/views/privacypolicy/privacypolicy.jsx Updated Terms of Use link reference
src/views/privacypolicy-apps/privacypolicy-apps.jsx Updated Privacy Policy and Terms of Use links
src/views/parents/parents.jsx Updated Privacy Policy links in parents section
src/views/cookies/cookies.jsx Updated all Privacy Policy link references in cookies table and text
src/routes.json Removed route definitions for internal privacy policy and terms of use pages
src/redux/session.js Removed /privacy_policy and /terms_of_use from ban exception list
src/components/privacy-banner/privacy-banner.jsx Updated Privacy Policy link in banner component
src/components/footer/www/footer.jsx Updated footer Terms of Use and Privacy Policy links

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KManolov3
Copy link
Contributor

This will address #9921 in making the links consistent (with the caveat, that freshdesk should be considered SoT, until the Terms of Use updates roll-out).

<dl>
<dd>
<a href="/terms_of_use">
<a href="https://mitscratch.freshdesk.com/en/support/solutions/articles/4000219182-scratch-terms-of-use">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the external links object (here and in other places) instead of hardcoding them. You can reference how it was done for a subset of the places in - a904c31

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

time. You can always find the latest version of the Terms of Use
at <a href="/terms_of_use">http://scratch.mit.edu/terms_of_use</a>.
at <a href="https://mitscratch.freshdesk.com/en/support/solutions/articles/4000219182-scratch-terms-of-use">
https://mitscratch.freshdesk.com/en/support/solutions/articles/4000219182-scratch-terms-of-use</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's a good question. I think it's better if the text stays as it was for now, but still refers to the freshdesk link. In any case, this page shouldn't be accessible through the regular flow (and will only be accessible via url).

@cwillisf what do you think?

@rosics-code
Copy link

Why not remove terms entirely? Terms of Use still mentions ScratchX which is now not working & it also has errors.

@kbangelov kbangelov force-pushed the bugfix/uepr-427-wrong-tou-and-privacy-policy-links branch from cb061fd to eddba78 Compare December 8, 2025 12:52
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<td><a href={externalLinks.scratchHelpDesk.privacyPolicy}>looks</a></td>
<td><a href={externalLinks.scratchHelpDesk.privacyPolicy}>good</a></td>
<td><a href={externalLinks.scratchHelpDesk.privacyPolicy}>to</a></td>
<td><a href={externalLinks.scratchHelpDesk.privacyPolicy}>me</a></td>

@KManolov3 KManolov3 merged commit dc5a8a6 into scratchfoundation:release/terms-of-use Dec 9, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants