[IPR-979] Omit multiple unnecessary project title update calls #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: test this with www before next release |
KManolov3
approved these changes
Aug 11, 2025
georgyangelov
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
onUpdateProjectTitleto avoid title updates for nonexistent projectonUpdateProjectTitleif the title has changed AND the project has loadedReason for Changes
There are multiple calls to
onUpdateProjectTitlewhile a project isn't actually loaded (e.g. the editor is in some "creating new" state). This causes multiple unnecessary and currently failing requests in WWW and side effects in other projects that integrate the editor.