-
Notifications
You must be signed in to change notification settings - Fork 46
feat(gui): add RTL support to delete-confirmation-prompt #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
this commit adds rtl support to the delete-confirmation-prompt of scratch-gui.
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA |
@pishi-ai, thanks for your help! I really appreciate the testing notes, too. |
@KManolov3, do you have time to review this? If not, let me know. |
This looks good! I think we should try to get it merged for one of the upcoming releases. |
Sorry for the bother, @pishi-ai, but could you merge from our It looks like something went wrong and prevented the normal build-and-test steps from running for this PR. I've adjusted our settings, so those steps should run if you make any changes to this PR. Merging from our |
9d25fd9
to
75ed706
Compare
I have read the CLA Document and I hereby sign the CLA |
This commit adds RTL (Right-to-Left) language support to the delete-confirmation-prompt component in scratch-gui.
Resolves
In RTL languages, when multiple sprites are opened, the confirmation prompt extends beyond the window boundary. This PR fixes that issue by properly handling RTL layout.
Proposed Changes
Reason for Changes
RTL language support is essential for accessibility and internationalization. Without proper handling, the confirmation prompt becomes unusable in RTL contexts. This update ensures consistent behavior and layout across both LTR and RTL languages.
Test Coverage