Make aggregation thread-safe (round 3: use RepositorySystemSession)#421
Merged
jozic merged 1 commit intoscoverage:mainfrom Feb 1, 2026
Merged
Conversation
b026001 to
78d8dff
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses thread-safety issues in aggregated coverage report generation by switching from MavenSession to RepositorySystemSession for build-global storage. This ensures proper synchronization across modules that may be loaded with different classloaders.
Changes:
- Replaced
MavenSessionwithRepositorySystemSessionfor coordinating aggregation across modules - Updated storage implementation to use backward-compatible get/set API instead of computeIfAbsent for Maven 3.6.3+ compatibility
- Added cleanup logic to remove data from session after aggregation is claimed
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/scoverage/plugin/SCoverageReportMojo.java | Injected RepositorySystemSession parameter and updated aggregation coordinator call to use it |
| src/main/java/org/scoverage/plugin/SCoverageAggregationCoordinator.java | Refactored to use RepositorySystemSession.getData() with backward-compatible synchronization approach |
| src/it/test_reactor_test_scoped_dependency/pom.xml | Updated description to remove reference to specific scenario name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It happens that maven can load different modules using different classloaders and that MavenSession's data is also not guaranteed to be the same across all modules. The solution is to use
RepositorySystemSessionto sync across all modules.For compatibility with Maven < 3.9, uses older get/set api
Checklist