Skip to content

Conversation

@TobiasBabin
Copy link
Contributor

@TobiasBabin TobiasBabin commented Oct 30, 2025

What is the motivation?

The "Update generated content" workflow currently fails because required directories are not present.

What does this change do?

The PR simplifies the download of the required input files default.provisioners.yaml for score-compose and zz-default.provisioners.yaml for score-k8s to use wget instead of a git read-tree which obtains the entire directories. That is not required. The change now also creates the target dirs first. This is done in package.json.

Note: The file transform-default-resource-provisioners.js deletes those directories after parsing the input files so the mkdir should not fail on the next run.

As an unrelated issues found during testing, the example page generation currently does not delete previously generated pages. Any source example files that have been removed from the sources will leave those pages behind, causing Hugo build errors because the embedded source files cannot be found anymore. The change to gen-example-pages.js addresses this issue.

What is your testing strategy?

I ran the command npm run gen-all that is executed by the "Update generated content" workflow locally.

Is this related to any issues?

No.

Have you read the Contributing Guidelines?

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TobiasBabin TobiasBabin merged commit 126378b into main Oct 30, 2025
6 checks passed
@TobiasBabin TobiasBabin deleted the fix-auto-generation branch October 30, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants