Stub out a callback handler#24
Open
matthewturk wants to merge 5 commits into
Open
Conversation
Change ray to pass-by-references to allow modification.
matthewturk
changed the title
Contributor
Author
|
This should be ready for review; I've stubbed out a python-based callback as well. The current CI failures seem related to conda base dependencies, I think. |
Owner
|
Thanks for putting this in Matt! |
scopatz
reviewed
Jul 9, 2020
| @@ -0,0 +1,49 @@ | |||
| from rtcore_ray cimport RTCRay | |||
Owner
There was a problem hiding this comment.
Please add docstrings to this file
Owner
|
Also, please add some tests too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress pull request to add callbacks. Examples are forthcoming, but the basic principle is that client code can
cimporttheRayCollisionCallbackobject and subclass it, then provide this to therun()method in theEmbreeScene.This callback can, for instance, adjust the direction of the rays, or make changes to an external array held onto by the
RayCollisionCallbackobject.