Jacob Ibáñez

src/main/java/com/scmspain/MsFcTechTestApplication.java

@@ -4,7 +4,6 @@
 import com.scmspain.configuration.TweetConfiguration;
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
-import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Import;
 

src/main/java/com/scmspain/services/TweetService.java

@@ -9,7 +9,9 @@
 import javax.persistence.TypedQuery;
 import javax.transaction.Transactional;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
+import java.util.stream.Collectors;
 
 @Service
 @Transactional
@@ -29,7 +31,10 @@ public TweetService(EntityManager entityManager, MetricWriter metricWriter) {
       Result - recovered Tweet
     */
     public void publishTweet(String publisher, String text) {
-        if (publisher != null && publisher.length() > 0 && text != null && text.length() > 0 && text.length() < 140) {
+
+        boolean publisherIsNotNullOrEmpty = publisher != null && publisher.length() > 0;
+
+        if (publisherIsNotNullOrEmpty && tweetIsValid(text)) {
             Tweet tweet = new Tweet();
             tweet.setTweet(text);
             tweet.setPublisher(publisher);
@@ -41,6 +46,23 @@ public void publishTweet(String publisher, String text) {
         }
     }
 
+    private boolean tweetIsValid(String tweet) {
+        String linkRegex = "(.*)https?://(.*)";
+        String space = " ";
+
+        String tweetWithoutLink = tweet;
+
+        if (tweet.matches(linkRegex)) {
+            tweetWithoutLink = Arrays.stream(tweet.split(space))
+                    .filter(word -> !word.matches(linkRegex))
+                    .collect(Collectors.joining(space));
+        }
+
+        boolean tweetIsNotNullOrEmpty = tweetWithoutLink != null && tweetWithoutLink.length() > 0;
+
+        return tweetIsNotNullOrEmpty && tweetWithoutLink.length() < 140;
+    }
+
     /**
       Recover tweet from repository
       Parameter - id - id of the Tweet to retrieve

src/test/java/com/scmspain/services/TweetServiceTest.java

@@ -35,4 +35,12 @@ public void shouldInsertANewTweet() throws Exception {
     public void shouldThrowAnExceptionWhenTweetLengthIsInvalid() throws Exception {
         tweetService.publishTweet("Pirate", "LeChuck? He's the guy that went to the Governor's for dinner and never wanted to leave. He fell for her in a big way, but she told him to drop dead. So he did. Then things really got ugly.");
     }
+
+    @Test
+    public void shouldIgnoreLinksForCharacterLimit() {
+        tweetService.publishTweet("LeChuck", "Please visit my personal web page http://makelechuckgreatagain.com, plenty of eighties stuff " +
+                "like Alf pictures, Madonna music and so on. #nostalgia #backtothe80s");
+
+        verify(entityManager).persist(any(Tweet.class));
+    }
 }