Skip to content

Conversation

@Desk3505
Copy link
Contributor

@Desk3505 Desk3505 commented Aug 1, 2025

Quick description

Please include a summary of the changes and the related issue(s) or improvement(s).
Please also include relevant motivation and context. List any dependencies that are required for this change if needed.

...

Type of change

RAP quack method implementation

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore requested a review from gabknight August 4, 2025 14:18
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to start the week :)
I didn't test it yet tho.

@Desk3505 Desk3505 requested a review from arnaudbore August 4, 2025 20:21
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.48%. Comparing base (8de071b) to head (76a2aed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   72.54%   72.48%   -0.06%     
==========================================
  Files         291      291              
  Lines       25072    25089      +17     
  Branches     3505     3506       +1     
==========================================
- Hits        18188    18186       -2     
- Misses       5394     5412      +18     
- Partials     1490     1491       +1     
Components Coverage Δ
Scripts 75.30% <75.00%> (-0.01%) ⬇️
Library ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "continue" option works.

image

There is a warning that is not your fault, but maybe you could modify it at the same time:
in scilpy.tracking.propagator, can you change line 405, which is

self.B = sh_to_sf_matrix(self.sphere, sh_order, self.basis,

to

self.B = sh_to_sf_matrix(self.sphere, sh_order=sh_order, basis_type=self.basis,

However, I could not install quactography to test the other method; the requirements in here https://github.com/scilus/quactography/blob/main/setup.cfg are not up-to-date with scilpy's here: https://github.com/scilus/scilpy/blob/master/pyproject.toml

@Desk3505 Desk3505 requested a review from EmmaRenauld August 28, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants