-
Notifications
You must be signed in to change notification settings - Fork 72
Quac rap #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Quac rap #1209
Conversation
arnaudbore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments to start the week :)
I didn't test it yet tho.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
- Coverage 72.54% 72.48% -0.06%
==========================================
Files 291 291
Lines 25072 25089 +17
Branches 3505 3506 +1
==========================================
- Hits 18188 18186 -2
- Misses 5394 5412 +18
- Partials 1490 1491 +1
🚀 New features to boost your workflow:
|
EmmaRenauld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "continue" option works.
There is a warning that is not your fault, but maybe you could modify it at the same time:
in scilpy.tracking.propagator, can you change line 405, which is
self.B = sh_to_sf_matrix(self.sphere, sh_order, self.basis,
to
self.B = sh_to_sf_matrix(self.sphere, sh_order=sh_order, basis_type=self.basis,
However, I could not install quactography to test the other method; the requirements in here https://github.com/scilus/quactography/blob/main/setup.cfg are not up-to-date with scilpy's here: https://github.com/scilus/scilpy/blob/master/pyproject.toml
Quick description
Please include a summary of the changes and the related issue(s) or improvement(s).
Please also include relevant motivation and context. List any dependencies that are required for this change if needed.
...
Type of change
RAP quack method implementation
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist