Skip to content

Conversation

@anroy1
Copy link
Contributor

@anroy1 anroy1 commented Jul 4, 2024

Describe your changes

Add the synthbet option to preproc_t1

List test packages used by your module

  • antsbet.zip
  • others.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

To Do

@anroy1 anroy1 added the WIP label Jul 4, 2024
@anroy1 anroy1 removed the WIP label Aug 1, 2024
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two small comments, great work 💯 Once addressed, this should be good to go !

@anroy1 anroy1 force-pushed the sw-preproc-t1 branch 2 times, most recently from a18d359 to e051d91 Compare August 9, 2024 13:38
@anroy1 anroy1 force-pushed the sw-preproc-t1 branch 2 times, most recently from 736caaf to 891d9d8 Compare September 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants