Skip to content

ci: update matrix to currently supported Node.js versions #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Mar 2, 2025

Dropped EOL 16, 17, 19, and added 23.
Pushed the array format to list format for easier diff in the future as items are added/removed.

Copy link
Owner

@schorfES schorfES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this. Could we please stick with version 16 for now? This package needs to support older Node versions as well (for example the grunt package).

Edit: Dropping v16 here means in general a dropped support for node 16, which then also needs an update here (package.json). Form what I saw, we possibly need to do this for this version bump of editorconfig.

Co-authored-by: Nick Schonning <[email protected]>
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (f1a96e0) to head (4a94161).
Report is 47 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   99.68%   99.69%           
=======================================
  Files           7        7           
  Lines         320      328    +8     
  Branches       90       96    +6     
=======================================
+ Hits          319      327    +8     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@schorfES schorfES merged commit 457c291 into schorfES:main May 30, 2025
18 checks passed
@nschonni nschonni deleted the patch-1 branch May 30, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants