Open
Conversation
schneidexe
reviewed
Nov 15, 2019
Owner
schneidexe
left a comment
schneidexe
left a comment
There was a problem hiding this comment.
Hey Schnappi, thanks for your contrib. Looks like I got notifications disabled on my own stuff so I just stumbled upon it...
| @@ -0,0 +1,6 @@ | |||
| if [ ! -d "${DST_PATH}" ]; then | |||
| mkdir -p ${DST_PATH} | |||
Owner
There was a problem hiding this comment.
I think this is not enough. If DEPTH is >1 you have to create sub dirs as well. Better to move this to L5 and use sub path of the src file to create dst sub path dirs.
| @@ -0,0 +1,13 @@ | |||
| FROM alpine | |||
|
|
|||
| ENV VERSION 0.4.5 | |||
| ENV VERSION 0.4.5 | ||
| ENV SRC_PATH /src | ||
| ENV DST_PATH /dest | ||
| ENV DEPTH 1 |
Owner
There was a problem hiding this comment.
I'd go with infinite depth as default...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Schnecke,
I added example docker file for your
tplbinary, it could be use as init Container inside i.e. Kubernetes.