Skip to content

Conversation

@BitsAndDroids
Copy link
Contributor

@BitsAndDroids BitsAndDroids commented Oct 31, 2025

What's changed

  • Moved the dependencies for the development project to a sub package.json
  • Removed angular dependencies from the dependencies and moved them to the peer dependencies. These packages were causing resolving issues. Therefore, components like the dropdown elements weren't working properly in the development app
  • Removed double rendering provider
  • Previously, the custom components were all present in the template (app.component.html). If you started the development project, you would only see a small subsection of the Calendar capabilities. I've commented out all custom components so users experience the full native calendar when developing. They can then easily comment out the custom components to see how it impacts the calendar. This felt more intuitive for developers.
  • Included "temporal-polyfill": "^0.3.0", in the peerdependencies of the library.

What's fixed

  • Reinstated publish in release command (my apologies, I accidentally removed the command).
  • Updated package.lock for failing CI
  • The development project works fully now.

@tomosterlund
Copy link
Contributor

tomosterlund commented Nov 6, 2025

Oh I'm sorry, I saw this too late after running npm i and pushing the changes to package-lock.json myself. But I think the merge conflict should be manageable since it's only the lock file.

Everything looks great to me, except the peer dependency on the Temporal polyfill. I decided against including it as a dependency, since a steadily growing number of apps will not need it, with Temporal being supported in Firefox and being flagged for release in January in Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants