Use scx_bpf_remote_curr() instead of scx_bpf_cpu_rq() #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even when the kernel patch gets merged, we need compat macros to keep the schedulers runnable on existing kernels. Can you wrap this around a macro? There's examples in the scheds/include/scx headers. |
Add the new kfunc scx_bpf_task_acquire_remote_curr() to provide a safer way to access an unlocked rq's curr. Signed-off-by: Christian Loehle <[email protected]>
The new scx_bpf_task_acquire_remote_curr() is safer to use, switch to it from scx_bpf_cpu_rq() as we only care about it's ->curr anyway. Signed-off-by: Christian Loehle <[email protected]>
The new scx_bpf_task_acquire_remote_curr() is safer to use, switch to it from scx_bpf_cpu_rq() as we only care about it's ->curr anyway. Signed-off-by: Christian Loehle <[email protected]>
The new scx_bpf_task_acquire_remote_curr() is safer to use, switch to it from scx_bpf_cpu_rq() as we only care about it's ->curr anyway. Signed-off-by: Christian Loehle <[email protected]>
The new scx_bpf_task_acquire_remote_curr() is safer to use, switch to it from scx_bpf_cpu_rq() as we only care about it's ->curr anyway. Signed-off-by: Christian Loehle <[email protected]>
The new scx_bpf_task_acquire_remote_curr() is safer to use, switch to it from scx_bpf_cpu_rq() as we only care about it's ->curr anyway. Signed-off-by: Christian Loehle <[email protected]>
cloehle
force-pushed
the
cloehle/scx-use-scx_bpf_remote_curr
branch
from
c06dbd3 to
ba2bb2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the conversion series for using the safer scx_bpf_remote_curr(),
which now also requires the schedulers to call bpf_task_release().
This is dependent on:
https://lore.kernel.org/lkml/[email protected]/
so obviously do not merge yet, but feel free to review.