Skip to content

Unwrap refined types for Java generic signatures#25626

Merged
SolalPirelli merged 3 commits intoscala:mainfrom
dotty-staging:solal/refined-signature
Apr 3, 2026
Merged

Unwrap refined types for Java generic signatures#25626
SolalPirelli merged 3 commits intoscala:mainfrom
dotty-staging:solal/refined-signature

Conversation

@SolalPirelli
Copy link
Copy Markdown
Contributor

Fixes #12199

How much have you relied on LLM-based tools in this contribution?

not

How was the solution tested?

issue test, modified to be fully automated

@SolalPirelli SolalPirelli marked this pull request as ready for review March 26, 2026 12:42
@SolalPirelli SolalPirelli requested a review from bishabosha March 26, 2026 12:42
Copy link
Copy Markdown
Member

@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SolalPirelli SolalPirelli merged commit 2688211 into scala:main Apr 3, 2026
64 checks passed
@SolalPirelli SolalPirelli deleted the solal/refined-signature branch April 3, 2026 08:26
@tanishiking
Copy link
Copy Markdown
Member

tanishiking commented Apr 3, 2026

Oops, now I realized @bishabosha is requested for review (#25632 as well) 🙇

@SolalPirelli
Copy link
Copy Markdown
Contributor Author

I think he's quite busy anyway so thanks for reviewing ❤️

tanishiking added a commit to tanishiking/scala3 that referenced this pull request Apr 4, 2026
We introduced a new flags for vc boxing/unboxing in
scala#25631
that renames `unboxedVCs` to `vcBoxing`.

While, we added new `unboxedVCs` usage in
scala#25626
that conflict with the former commit.

This commit fixes the conflict by using `unboxedVCs`.
tanishiking added a commit that referenced this pull request Apr 4, 2026
We introduced a new flags for vc boxing/unboxing in
#25631
that renames `unboxedVCs` to `vcBoxing`.

While, we added new `unboxedVCs` usage in
#25626
that conflict with the former commit.

This commit fixes the conflict by using `unboxedVCs`.

<!-- Fixes #XYZ (where XYZ is the issue number from the issue tracker)
-->

<!-- TODO description of the change -->
<!-- Ideally should have a title like "Fix #XYZ: Short fix description"
-->

<!--
  TODO first sign the CLA
  https://contribute.akka.io/cla/scala
-->

<!-- if the PR is still a WIP, create it as a draft PR (or convert it
into one) -->

## How much have you relied on LLM-based tools in this contribution?

not

<!-- 
  State clearly in the pull request description, 
  whether LLM-based tools were used and to what extent 

  (extensively/moderately/minimally/not at all)
-->

<!--
Refer to our [LLM usage
policy](https://github.com/scala/scala3/blob/main/LLM_POLICY.md) for
rules and guidelines
  regarding usage of LLM-based tools in contributions.
-->

## How was the solution tested?

test `testCompilation` runs

<!-- 
  If automated tests are included, mention it.
  If they are not, explain why and how the solution was tested.
-->

## Additional notes

<!-- Placeholder for any extra context regarding this contribution. -->

<!--
When in doubt, and for support regarding contributions to a particular
component of the compiler,
refer to [our contribution
guide](https://github.com/scala/scala3/blob/main/CONTRIBUTING.md),
and feel free to tag the maintainers listed there for the area(s) you
are modifying.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refinement creates raw type in Java generic signature

3 participants