Challenge oracles #377
Draft
Challenge oracles #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table header for clarity
…suring proper handling of oracle additions and price settings. Remove unnecessary fromBlock parameters in WhitelistTable component event listeners for cleaner code.
- whitelist as factory contract - create library which includes sort and gerMedian - use custom errors - update deploy script - fix frontend accordingly
…n price deviations
Updated image links in the README to point to GitHub assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This past PR closed when I rebased to the base-challenge-template branch. Oops.
#353
This PR has addressed all the feedback given in that past PR. The changes are somewhat extensive when it comes to the Staking oracle which now has an interactive front-end plus a huge change related to slashing - now slashing occurs when the reported price of a node deviates from the average.
Solutions to the contracts can be found here: https://github.com/BuidlGuidl/oracle-challenge/tree/main/packages/hardhat/contracts
Please let me know what thoughts you have.
Currently awaiting a contract review from @phipsae then I will change our of draft