feat: properly handle Decimal and strings#653
Open
azelcer wants to merge 1 commit intosavoirfairelinux:masterfrom
Open
feat: properly handle Decimal and strings#653azelcer wants to merge 1 commit intosavoirfairelinux:masterfrom
azelcer wants to merge 1 commit intosavoirfairelinux:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603
Changes proposed in this pull request:
strandDecimalobjects to cardinals honours the precision of those representations.strandDecimalobjects to cardinals do not introduce floating-point representation errors.Status
How to verify this change
Decimalandstrtaking in account the exact values representedAdditional notes
Some values are not exactly representable as per IEEE 754 standard (the issue #603 that initiated this PR deals with number
98_746_251_323_029.99). Nevertheless, those values have an exact representation asDecimalorstrobjects. Currently the library converts these types to floats before processing, introducing floating-point inaccuracies. I have added a separate path for dealing with these number representation formats.