Fixes #559 by Paola L. & Sydney F. #633
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559 by Paola L. & Sydney F.
Changes proposed in this pull request:
Fixed a bug where certain numbers like 1210 would cause a TypeError: cannot unpack non-iterable NoneType object.
Added new unit tests to check that num2words can safely handle numbers like 1210, 1_000_000, and 1_000_000_000 in Amharic without raising errors.
Status
How to verify this change
Run the full Amharic language unit tests:
python3 -m unittest tests/test_am.py
Confirm that no TypeError is raised when converting numbers such as 1210, 1000000, and 1000000000 using num2words(lang="am"). Confirm that all tests pass successfully, indicating that numbers are now handled safely in the Amharic language module.
Additional notes