Fixed Amharic Infinite Loop for 568476685 and Other Large Numbers #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mrodriguezg1991 |
1 task
bryananderson
added a commit
to bryananderson/num2words
that referenced
this pull request
Jan 9, 2025
bryananderson
added a commit
to bryananderson/num2words
that referenced
this pull request
Jan 9, 2025
…nux#598) and fix formatting
mrodriguezg1991
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Update base.py to remove cents from displaying when whole number inputted * Update test_en.py to align with updated base.py * Update test_en_ng.py to align with updated base.py * Update test_hu.py to align with updated base.py * Update test_nl.py to align with updated base.py * Update test_am.py to align with updated base.py * Remove Amharic cardinals test cases meant for other PR (#598) and fix formatting --------- Co-authored-by: cheng-jess <[email protected]>
|
Hi @cheng-jess, do you plan to fix the tests failing only for a style issue (with flake8 "line too long") ? |
Contributor
Author
|
Hi @elishowk, I'm not planning on fixing the style issue right now, so feel free to work on it if you'd like. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591 by eliminating infinite loop
Changes proposed in this pull request:
Status
How to verify this change
Test with num2words(568476685, lang="am") or "num2words 568476685 -l am" in the command line. Can also run the test_am.py file to check with test case/assert statement.
Additional notes
Fixed Issue #591