Open
Conversation
marcoow
suggested changes
Oct 6, 2017
Contributor
marcoow
left a comment
marcoow
left a comment
There was a problem hiding this comment.
Thanks for the effort! I don't think we should by changing the Rails dependency as part of this though.
Gemfile
Outdated
| source "http://rubygems.org" | ||
|
|
||
| gem 'rails', '~> 4.1.0' | ||
| gem 'rails', '~> 5.0.1' |
Contributor
There was a problem hiding this comment.
Why update this to require Rails 5? I think ideally this should work with both 4 and 5 but seems unrelated to the Ruby 2.3.1 fix anyways?
reportable.gemspec
Outdated
|
|
||
| s.name = %q{reportable} | ||
| s.version = '1.4.2' | ||
| s.version = '1.5.0' |
Contributor
There was a problem hiding this comment.
I think incrementing the version is unrelated and should be done in a separate PR. Also this would be a patch release as it only fixes a bug and doesn't actually add anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.