Skip to content

is_file_path_match now skips over "./" and ".\\" prefix, if present #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robinvierich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

is_file_path_match now skips over "./" and ".\\" prefix, if present #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions include/lrdb/debugger.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,35 @@ class debugger {

static bool is_file_path_match(const char* path1, const char* path2) {
// TODO need more inteligent?
int i = 0;

int c1_i = 0;
int c2_i = 0;


// TODO probably normalize paths generically here (instead of just checking for explicit prefixes), if fast enough..
// check for "./" prefix
const char* path_with_prefix = (path1[0] == '.') ? path1 : ((path2[0] == '.') ? path2 : nullptr);

if (path1[0] == '.' && path2[0] != '.')
{
if (path1[1] == '/' || path1[1] == '\\')
{
// skip the first 2 characters of path1
c1_i += 2;
}
}
else if (path2[0] == '.' && path1[0] != '.')
{
if (path2[1] == '/' || path2[1] == '\\')
{
// skip the first 2 characters of path2
c2_i += 2;
}
}

while (true) {
char c1 = path1[i];
char c2 = path2[i];
char c1 = path1[c1_i];
char c2 = path2[c2_i];

if (c1 != c2) {
// allow different backslash and slash for windows
Expand All @@ -812,7 +837,8 @@ class debugger {
if (c1 == '\0') {
return true;
}
i++;
c1_i++;
c2_i++;
}
}

Expand Down