Skip to content

build/nix: Update flake inputs#304

Open
bjackman wants to merge 1 commit into
sashiko-dev:mainfrom
bjackman:nix-updates
Open

build/nix: Update flake inputs#304
bjackman wants to merge 1 commit into
sashiko-dev:mainfrom
bjackman:nix-updates

Conversation

@bjackman

Copy link
Copy Markdown
Contributor

Effectively this just updates naersk (Cargo->Nix integration) and the Rust toolchain.

No particular reason to do this right now but may as well bump it while I'm waiting for the code to compile.

@rgushchin

Copy link
Copy Markdown
Member

Can you please add your SOB line?

The `sashiko local` command uses the passed repo in its own code, e.g.
to resolve commits, but then doesn't pass the repo through to the review
subprocess. This means if the repo in your Settings.toml doesn't match
the --repo arg you will get confusing errors as it fails to identify
your commit messages.

Signed-off-by: Brendan Jackman <jackmanb@google.com>
@bjackman

Copy link
Copy Markdown
Contributor Author

Sorry done

@rgushchin

Copy link
Copy Markdown
Member

Wait, it's a different commit now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants