[BREAKING_CHANGES] Stop stripping dots in azure model mapper #1079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dots (.) are valid model and deployments names in Azure AI Foundry deployments for all models newer than 3.5, and without customization the deployment name matches the model name so it seems sensible to leave them in for non 3.5 models.
I kept the original : stripping in place, not entirely sure what that was originally there for but i haven't found issues around it for now
Similar almost complete PR found here, but the original author closed it: #1004
Fixes this issue: #978