Skip to content

Conversation

krissetto
Copy link

Dots (.) are valid model and deployments names in Azure AI Foundry deployments for all models newer than 3.5, and without customization the deployment name matches the model name so it seems sensible to leave them in for non 3.5 models.

I kept the original : stripping in place, not entirely sure what that was originally there for but i haven't found issues around it for now

Similar almost complete PR found here, but the original author closed it: #1004

Fixes this issue: #978

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.59%. Comparing base (8e5611c) to head (1a1593d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1079   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          34       34           
  Lines        2206     2209    +3     
=======================================
+ Hits         2197     2200    +3     
  Misses          6        6           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant