Skip to content

fix: add liveness-browser.mjs to SYSTEM_PATHS for update bug (#704)#709

Open
VishnuVardhan34 wants to merge 2 commits into
santifer:mainfrom
VishnuVardhan34:fix-updater-include-liveness-browser
Open

fix: add liveness-browser.mjs to SYSTEM_PATHS for update bug (#704)#709
VishnuVardhan34 wants to merge 2 commits into
santifer:mainfrom
VishnuVardhan34:fix-updater-include-liveness-browser

Conversation

@VishnuVardhan34
Copy link
Copy Markdown

@VishnuVardhan34 VishnuVardhan34 commented May 20, 2026

What does this PR do?

Related issue

Type of change

  • Bug fix
  • New feature
  • Documentation / translation
  • Refactor (no behavior change)

Checklist

  • I have read CONTRIBUTING.md
  • I linked a related issue above (required for features and architecture changes)
  • My PR does not include personal data (CV, email, real names)
  • I ran node test-all.mjs and all tests pass
  • My changes respect the Data Contract (no modifications to user-layer files)
  • My changes align with the project roadmap

Questions? Join the Discord for faster feedback.

Summary by CodeRabbit

  • Chores
    • Enhanced system-level update process to properly manage all necessary components during auto-update operations.

Review Change Stack

@github-actions
Copy link
Copy Markdown
Contributor

Welcome to career-ops, @VishnuVardhan34! Thanks for your first PR.

A few things to know:

  • Tests will run automatically — check the status below
  • Make sure you've linked a related issue (required for features)
  • Read CONTRIBUTING.md if you haven't

We'll review your PR soon. Join our Discord if you have questions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

📝 Walkthrough

Walkthrough

Added liveness-browser.mjs to the SYSTEM_PATHS allowlist in update-system.mjs, enabling the apply and rollback subcommands to include this script in system-layer auto-updates.

Changes

System Updater Configuration

Layer / File(s) Summary
System paths allowlist expansion
update-system.mjs
Added liveness-browser.mjs to SYSTEM_PATHS array so apply and rollback subcommands fetch, update, and restore this script as part of system-layer operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

  • santifer/career-ops#600: Both PRs expand the SYSTEM_PATHS allowlist in update-system.mjs to include additional scripts in system-layer operations.
  • santifer/career-ops#366: Both PRs add liveness-related system scripts to SYSTEM_PATHS for auto-update management.

Suggested labels

🔧 scripts

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding liveness-browser.mjs to SYSTEM_PATHS to fix an update bug, which matches the single-line code change in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wyl2607
Copy link
Copy Markdown

wyl2607 commented May 25, 2026

Thanks for the fix. Main now includes the updater change ( is already in ) and this PR has no remaining changed files after syncing, while #704 is closed. Closing this as superseded by the current main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants