Add trace-collector service #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pesa
reviewed
Feb 28, 2025
docker-compose.yml
Outdated
| driver: local | ||
|
|
||
| trace-collector: | ||
| image: sankalpatimilsina/scheduler:latest |
There was a problem hiding this comment.
What's this and why is it on your personal account? And let's not use latest please.
Owner
Author
There was a problem hiding this comment.
This is supposed to be pointing to Docker hub.
Owner
Author
There was a problem hiding this comment.
docker-compose.yml
Outdated
| network_mode: service:nfd | ||
| volumes: | ||
| - /home/.ssh:/root/.ssh:ro | ||
| - /home/ndnops/ndntdump-exp-2023:/dump |
There was a problem hiding this comment.
We should probably rename the directory at this point, "exp-2023" is no longer very relevant.
sankalpatimilsina12
force-pushed
the
feature/trace-collector-service
branch
from
1199061 to
6d82848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds trace-collector service.
I am not sure about the
.sshand/dumpmounts.