Course Card Popover #207
Open
Course Card Popover #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
sanjana-singhania
force-pushed
the
206-course-card-popup
branch
from
21079be to
98aa5e7
Compare
sanjana-singhania
force-pushed
the
206-course-card-popup
branch
from
98aa5e7 to
4e72719
Compare
sanjana-singhania
requested review from
ItsEricSun,
Sarah-Zhang1,
aarowz and
jpnortonwastaken
kaiyangzheng
approved these changes
Dec 7, 2025
mehallhm
requested changes
Dec 10, 2025
Collaborator
mehallhm
left a comment
mehallhm
left a comment
There was a problem hiding this comment.
a couple of other remarks:
- I think I am going to go through and remove all the default tailwindcss colors. that would strong arm people to use our design system since there is still stuff coming through the cracks (I SEE YOU AI USAGE... I ALWAYS KNOW [not targeted at you just the teams in general])
- I think I need to do an audit / PR with some refactoring changes... I have been more generous in these PRs since there has not been clear code style guidelines yet. Next sem I already have some docs being drafted, but I think I am going to walk the codebase and find things that can just be improved. you guys are going hard on the features, but there is some little stuff that I would like to fix
neither of those are immediate concerns, but will be implemented slowly throughout break
| className={` | ||
| px-3 py-2 rounded-lg border whitespace-nowrap font-bold flex items-center gap-2 text-neu8 | ||
| ${currentCourseGroupIndex === index | ||
| ? "border-neu3 bg-white" |
Collaborator
There was a problem hiding this comment.
more default colors that need to be fixed
sanjana-singhania
force-pushed
the
206-course-card-popup
branch
from
71c3fd8 to
6d08fb3
Compare
Member
Author
|
mehallhm
approved these changes
Jan 1, 2026
Collaborator
mehallhm
left a comment
mehallhm
left a comment
There was a problem hiding this comment.
looks much better. be sure your branch is up to date from main. that said, i can still smell the ai code and there is still some sloppy code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206
Displays a popover for the section on click.
Added building and room number to meeting time.
Removes the duplicate classes in filter bar (oops) and also removes "clear filtering" to stay up to date with figma designs.