-
Notifications
You must be signed in to change notification settings - Fork 4
feat(site-blocklist): add site-specific blocklist with UI and sync storage support #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @samzong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a highly requested feature: a site-specific blocklist. This allows users to control where TabBoost's content scripts are active, addressing scenarios where the extension might interfere with native site functionalities. The implementation includes a comprehensive UI for managing blocked sites, intelligent matching logic for various URL patterns, and seamless integration with the extension's lifecycle and storage mechanisms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Build Status: ✅ Tests passedThis PR has been automatically tested by GitHub Actions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a site-specific blocklist feature, allowing users to disable the extension on certain websites. The implementation includes a new UI in the options page, a quick-disable button in the popup, and leverages sync storage. The design is well-documented, and the core logic is encapsulated in a new siteBlocklist.js utility. My review focuses on the correctness of the matching logic, potential performance improvements, code consistency, and localization accuracy. I've identified a bug in the wildcard matching, a deviation from the design regarding caching, and some areas for code cleanup and consistency improvements.
7241150 to
cd1c455
Compare
Build Status: ✅ Tests passedThis PR has been automatically tested by GitHub Actions.
|
…orage support Signed-off-by: samzong <[email protected]>
cd1c455 to
9887ca6
Compare
Build Status: ✅ Tests passedThis PR has been automatically tested by GitHub Actions.
|
fix #67