Skip to content

Conversation

@samzong
Copy link
Owner

@samzong samzong commented Nov 8, 2025

fix #67

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @samzong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a highly requested feature: a site-specific blocklist. This allows users to control where TabBoost's content scripts are active, addressing scenarios where the extension might interfere with native site functionalities. The implementation includes a comprehensive UI for managing blocked sites, intelligent matching logic for various URL patterns, and seamless integration with the extension's lifecycle and storage mechanisms.

Highlights

  • Site-Specific Blocklist: Introduced a new feature allowing users to disable TabBoost's content script functionalities on specific websites, preventing conflicts with critical workflows.
  • User Interface: Added a dedicated 'Website Blocklist' section under a new 'Advanced Settings' tab in the options page for managing blocked sites. A quick 'Disable/Enable on this site' button is also available in the extension popup.
  • Content Script Integration: Content scripts now check the blocklist status early in their lifecycle and abort initialization if the current site is blocked. They also listen for blocklist changes to dynamically adapt.
  • Persistent Storage & Matching Logic: The blocklist configuration is stored using chrome.storage.sync for persistence across devices. A new utility module handles pattern normalization, infers match types (domain, wildcard, prefix, regex), and builds matchers to determine if a URL should be bypassed.
  • Visual Feedback: The extension's badge icon now displays a '×' on blocked sites, providing immediate visual feedback to the user.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Build Status: ✅ Tests passed

This PR has been automatically tested by GitHub Actions.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a site-specific blocklist feature, allowing users to disable the extension on certain websites. The implementation includes a new UI in the options page, a quick-disable button in the popup, and leverages sync storage. The design is well-documented, and the core logic is encapsulated in a new siteBlocklist.js utility. My review focuses on the correctness of the matching logic, potential performance improvements, code consistency, and localization accuracy. I've identified a bug in the wildcard matching, a deviation from the design regarding caching, and some areas for code cleanup and consistency improvements.

@samzong samzong force-pushed the feature/website-blocklist branch from 7241150 to cd1c455 Compare November 8, 2025 18:16
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Build Status: ✅ Tests passed

This PR has been automatically tested by GitHub Actions.

@samzong samzong force-pushed the feature/website-blocklist branch from cd1c455 to 9887ca6 Compare November 8, 2025 18:18
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Build Status: ✅ Tests passed

This PR has been automatically tested by GitHub Actions.

@samzong samzong merged commit 2d3cf85 into main Nov 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website blocklist

2 participants