⚙️ disable batch upload feature main

[sjproctor]

Fixes

This commit prevents admin users from enabling batch_upload in settings.
This addresses the issue that batch uploads and Valkyrized works are
incompatible. The current Batch Add uses a fake Active Fedora form with
fixed terms that ignore the selected work type, causing Valkyrie
validations to fail (especially on 6.2).

It was determined that fixing this issue is low-priority compared to
general Bulkrax improvements. To ensure users are not enabling broken
features, batch_upload is disabled until further decisions are made.

Ref:

• Disable / Deprecate the Batch Create feature notch8/palni_palci_knapsack#479

Type of change (for release notes)

Add an appropriate notes-* label to the PR (or indicate here) that classifies this change.

Choose from:

• notes-major Major Changes (Potentially breaking changes)
• notes-minor New Features that are backward compatible
• notes-deprecation Deprecations
• notes-bugfix Bug Fixes
• notes-valkyrie Valkyrie Progress
• notes-docs Documentation
• notes-container Containerization related (Docker, Helm, etc)

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    13 files  ±0      13 suites  ±0   2h 49m 25s ⏱️ - 4m 43s
 6 907 tests ±0   6 599 ✅  - 2  308 💤 +2  0 ❌ ±0 
18 349 runs  +1  17 842 ✅  - 5  507 💤 +6  0 ❌ ±0 

Results for commit 9f83c59. ± Comparison against base commit 23613bb.

This pull request removes 360 and adds 360 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f34687f3480>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f82bd7d2318>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa0879eb680>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3467f885c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f82bd7e6cc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa087a63220>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: fd09d77f-3abe-43c0-9431-0f84534c9410
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4a5c4817-149b-49df-a18e-b3af0e021872
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: a16d5ad4-0e0d-4547-b701-2bd35c1fe053
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 0a7f271f-81c9-462a-a1f7-9df50dbd2f0e
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2e2dd21ba0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fab6c101548>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fea214abba0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2e2dc17598>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fab6c0f3718>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fea213ff8c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ba449645-132e-4fc2-884d-aa5da0b08904
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 429679c6-248a-4758-a7b0-cb02cf514dae
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 6e9ac079-43ad-4b36-b6ca-808c51814793
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 20db7c0e-051f-4af6-81a0-402c0d80acd2
…

This pull request skips 2 tests.

spec.features.batch_edit_spec ‑ batch editing changes the value of each field for all selected works
spec.features.batch_edit_spec ‑ batch editing updates visibility

♻️ This comment has been updated with latest results.

[randalldfloyd]

This solution is solid and it tests out for me locally; but we're going to defer to product owners long enough to come to a consensus on if it should be disabled in Hyrax. So I'll wait to merge to see how that goes.

[sjproctor]

@randalldfloyd Thanks! Sounds good to me. I wanted to document the change since we added it to 5.0-flexible.