Conversation
Test Results 13 files ±0 13 suites ±0 2h 46m 6s ⏱️ - 5m 9s For more details on these failures, see this check. Results for commit 131b88a. ± Comparison against base commit 5b03f59. This pull request removes 366 and adds 367 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Hi @rodyoukai -- I think you may have requested review from the wrong user. Best -- Mat |
|
Hi @mathewjordan, Im so sorry, I took the suggestion of GitHub, my apologies |
…-meet-WCAG-AA-minimum-color-contrast-requirements
orangewolf
left a comment
There was a problem hiding this comment.
I'm concerned about unintended styling changes here. .btn-link is used in several other places. Could we scope it to .btn-link.add so it only affects this one button or can you confirm you looked at the collections and file versioning usages and that they also tolerate this change?
|
Hi @orangewolf, I have applied the changes you suggested to the code. |
…-meet-WCAG-AA-minimum-color-contrast-requirements
…-meet-WCAG-AA-minimum-color-contrast-requirements
…-meet-WCAG-AA-minimum-color-contrast-requirements
Fix #6796
Now the constrast in "Add another" buton is acceptable