Skip to content

WIP Bootstrap 5#6912

Draft
dlpierce wants to merge 8 commits intomainfrom
bs5
Draft

WIP Bootstrap 5#6912
dlpierce wants to merge 8 commits intomainfrom
bs5

Conversation

@dlpierce
Copy link
Member

@dlpierce dlpierce commented Oct 2, 2024

Fixes

Fixes #6904

Summary

Upgrade to Bootstrap 5

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Website loads with no major layout style issues

Changes proposed in this pull request:

  • Update to Bootstrap 5 framework, modifying JS and SCSS as needed.

@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Oct 2, 2024
@dlpierce
Copy link
Member Author

dlpierce commented Oct 2, 2024

Currently blocked by changes needed in Browse Everything:

SassC::SyntaxError: Error: The target selector was not found. (SassC::SyntaxError)
db_migrate-1  |        Use "@extend .mr-2 !optional" to avoid this error.
db_migrate-1  |         on line 73 of ../../bundle/ruby/3.2.0/gems/browse-everything-1.3.0/app/assets/stylesheets/browse_everything/_browse_everything_bootstrap4.scss
db_migrate-1  | >>       @extend .mr-2;

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

Test Results

0 files   -     17  0 suites   - 17   0s ⏱️ - 2h 23m 27s
0 tests  -  6 705  0 ✅  -  6 407  0 💤  - 297  0 ❌  - 1 
0 runs   - 13 180  0 ✅  - 12 784  0 💤  - 395  0 ❌  - 1 

Results for commit d3f7031. ± Comparison against base commit aeb5e3e.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes-minor Release Notes: Non-breaking features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Bootstrap 5 in Hyrax

2 participants