Improve jinja-latex highlighting and folding #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `*` and `#` to 'surroundingPairs`, so a selection can be surrounded with `((* *))` and `((# #))`. Previously the selection would be deleted as soon as `*` or `#` is typed after the two opening parentheses.
- folding configuration in language-configuration-latex.json seems to take precedence over that in jinja-latex.tmLanguage.json --> remove from latter - add some additional keywords which can denote blocks to be folded. NB: Only enable folding for block assignments, i.e. exlude the code blocks with a "set" tag from being a folding start marker when a value is assigned to the variable within the code block.
- add some missing keywords / symbols - update scope names to improve highlighting
choeppler
force-pushed
the
improve-latex
branch
from
45dc3eb to
c41fe74
Compare
Author
|
In the force push I just restructured the commits. |
|
Hi @samuelcolvin thanks for the amazing extension for VS Code. This looks like an improvement for LaTex templates, why this has been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen from the first screenshot below, currently syntax highlighting is inconsistent in jinja-latex mode. I tried to fix this by the patch submitted in this PR. The second screenshot taken "after applying the patches" shows the resulting behavior. To ease testing, I added the example as first commit (8e2d469) and the functional changes in subsequent commits.
Additionally, the folding config has been updated, so all types of blocks should fold correctly now even if there is no indentation (which seems to add its own folding logic).
Finally, the minor update to the surroundingPairs config now allows a selection to be surrounded with
((* *))or((# #)). Previously the selection would be deleted as soon as*or#is typed after the two opening parentheses.Before applying the patches:
After applying the patches:
edit: update commit reference after force push