[do not merge] Dotnet core upgrade#31
Open
luk355 wants to merge 4 commits into
Open
Conversation
Author
|
any feedback, @samjudson? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @samjudson,
I did a bit of investigation on how much effort is required to migrate your library to .net core. In the pull request, you can see compiling version of multi-targeted library currently supporting:
The project can be compiled either by VS or by dotnet cli tool executing
dotnet build FlickrNet\FlickrNet.csproj.I am currently missing support for Silverlight, Monotouch and WindowsCE as I dont have these libraries installed on my computer and therefore I cannot compile the solution once I add these targets. However, to add support for these should be as easy as adding platform targets for these frameworks into
TargetFrameworkstag in FlickrNet.csproj file (and uncommenting the commented out code).If we went down this path, we would essentially end up with with one project targeting all the frameworks and one NuGet package.
The other option would be to create project just for .net standard which would result in a code duplication.
What are you thoughts on this?