-
Notifications
You must be signed in to change notification settings - Fork 0
[FEAT] 이력서 기반 면접 목록 이력서 기반 폴더링 API #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
api/src/main/java/com/samhap/kokomen/interview/service/dto/PortfolioInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.samhap.kokomen.interview.service.dto; | ||
|
|
||
| import com.samhap.kokomen.resume.domain.MemberPortfolio; | ||
|
|
||
| public record PortfolioInfo(String name, String url) { | ||
|
|
||
| public static PortfolioInfo fromNullable(MemberPortfolio portfolio) { | ||
| if (portfolio == null) { | ||
| return null; | ||
| } | ||
| return new PortfolioInfo(portfolio.getTitle(), portfolio.getPortfolioUrl()); | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
...c/main/java/com/samhap/kokomen/interview/service/dto/QuestionGenerationStateResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.samhap.kokomen.interview.service.dto; | ||
|
|
||
| import com.samhap.kokomen.interview.domain.ResumeQuestionGenerationState; | ||
|
|
||
| public record QuestionGenerationStateResponse( | ||
| ResumeQuestionGenerationState state | ||
| ) { | ||
| public static QuestionGenerationStateResponse of(ResumeQuestionGenerationState state) { | ||
| return new QuestionGenerationStateResponse(state); | ||
| } | ||
| } |
11 changes: 0 additions & 11 deletions
11
.../main/java/com/samhap/kokomen/interview/service/dto/QuestionGenerationStatusResponse.java
This file was deleted.
Oops, something went wrong.
13 changes: 13 additions & 0 deletions
13
api/src/main/java/com/samhap/kokomen/interview/service/dto/ResumeInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.samhap.kokomen.interview.service.dto; | ||
|
|
||
| import com.samhap.kokomen.resume.domain.MemberResume; | ||
|
|
||
| public record ResumeInfo(String name, String url) { | ||
|
|
||
| public static ResumeInfo fromNullable(MemberResume resume) { | ||
| if (resume == null) { | ||
| return null; | ||
| } | ||
| return new ResumeInfo(resume.getTitle(), resume.getResumeUrl()); | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
...n/java/com/samhap/kokomen/interview/service/dto/ResumeQuestionGenerationPageResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package com.samhap.kokomen.interview.service.dto; | ||
|
|
||
| import java.util.List; | ||
| import org.springframework.data.domain.Page; | ||
|
|
||
| public record ResumeQuestionGenerationPageResponse( | ||
| List<ResumeQuestionGenerationResponse> data, | ||
| int currentPage, | ||
| long totalCount, | ||
| int totalPages, | ||
| boolean hasNext | ||
| ) { | ||
| public static ResumeQuestionGenerationPageResponse of( | ||
| List<ResumeQuestionGenerationResponse> data, | ||
| Page<?> page | ||
| ) { | ||
| return new ResumeQuestionGenerationPageResponse( | ||
| data, | ||
| page.getNumber(), | ||
| page.getTotalElements(), | ||
| page.getTotalPages(), | ||
| page.hasNext() | ||
| ); | ||
| } | ||
| } |
26 changes: 26 additions & 0 deletions
26
.../main/java/com/samhap/kokomen/interview/service/dto/ResumeQuestionGenerationResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package com.samhap.kokomen.interview.service.dto; | ||
|
|
||
| import com.samhap.kokomen.interview.domain.ResumeQuestionGeneration; | ||
| import com.samhap.kokomen.interview.domain.ResumeQuestionGenerationState; | ||
| import java.time.LocalDateTime; | ||
|
|
||
| public record ResumeQuestionGenerationResponse( | ||
| Long id, | ||
| String jobCareer, | ||
| ResumeQuestionGenerationState state, | ||
| LocalDateTime createdAt, | ||
| ResumeInfo resume, | ||
| PortfolioInfo portfolio | ||
| ) { | ||
|
|
||
| public static ResumeQuestionGenerationResponse from(ResumeQuestionGeneration generation) { | ||
| return new ResumeQuestionGenerationResponse( | ||
| generation.getId(), | ||
| generation.getJobCareer(), | ||
| generation.getState(), | ||
| generation.getCreatedAt(), | ||
| ResumeInfo.fromNullable(generation.getMemberResume()), | ||
| PortfolioInfo.fromNullable(generation.getMemberPortfolio()) | ||
| ); | ||
| } | ||
| } |
62 changes: 62 additions & 0 deletions
62
...a/com/samhap/kokomen/global/fixture/interview/ResumeQuestionGenerationFixtureBuilder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| package com.samhap.kokomen.global.fixture.interview; | ||
|
|
||
| import com.samhap.kokomen.interview.domain.ResumeQuestionGeneration; | ||
| import com.samhap.kokomen.interview.domain.ResumeQuestionGenerationState; | ||
| import com.samhap.kokomen.member.domain.Member; | ||
| import com.samhap.kokomen.resume.domain.MemberPortfolio; | ||
| import com.samhap.kokomen.resume.domain.MemberResume; | ||
|
|
||
| public class ResumeQuestionGenerationFixtureBuilder { | ||
|
|
||
| private Member member; | ||
| private MemberResume memberResume; | ||
| private MemberPortfolio memberPortfolio; | ||
| private String jobCareer; | ||
| private ResumeQuestionGenerationState state; | ||
|
|
||
| public static ResumeQuestionGenerationFixtureBuilder builder() { | ||
| return new ResumeQuestionGenerationFixtureBuilder(); | ||
| } | ||
|
|
||
| public ResumeQuestionGenerationFixtureBuilder member(Member member) { | ||
| this.member = member; | ||
| return this; | ||
| } | ||
|
|
||
| public ResumeQuestionGenerationFixtureBuilder memberResume(MemberResume memberResume) { | ||
| this.memberResume = memberResume; | ||
| return this; | ||
| } | ||
|
|
||
| public ResumeQuestionGenerationFixtureBuilder memberPortfolio(MemberPortfolio memberPortfolio) { | ||
| this.memberPortfolio = memberPortfolio; | ||
| return this; | ||
| } | ||
|
|
||
| public ResumeQuestionGenerationFixtureBuilder jobCareer(String jobCareer) { | ||
| this.jobCareer = jobCareer; | ||
| return this; | ||
| } | ||
|
|
||
| public ResumeQuestionGenerationFixtureBuilder state(ResumeQuestionGenerationState state) { | ||
| this.state = state; | ||
| return this; | ||
| } | ||
|
|
||
| public ResumeQuestionGeneration build() { | ||
| ResumeQuestionGeneration generation = new ResumeQuestionGeneration( | ||
| member, | ||
| memberResume, | ||
| memberPortfolio, | ||
| jobCareer != null ? jobCareer : "신입" | ||
| ); | ||
|
|
||
| if (state == ResumeQuestionGenerationState.COMPLETED) { | ||
| generation.complete(); | ||
| } else if (state == ResumeQuestionGenerationState.FAILED) { | ||
| generation.fail(); | ||
| } | ||
|
Comment on lines
+46
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial 필수 필드 기본값 또는 명시적 검증 추가를 고려해 주세요. 🤖 Prompt for AI Agents |
||
|
|
||
| return generation; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잘못된 resume_id/portfolio_id가 조용히 무시됩니다.
ID가 제공됐는데 소유/존재 확인이 실패하면
null로 처리되어 요청이 성공 처리될 수 있습니다. 명시적으로 400을 반환하는 것이 안전합니다.🔧 수정 제안
🤖 Prompt for AI Agents