Fix Convex shell environment handling - #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Convex already supplies
VITE_CONVEX_URL:convex devwrites it for local development, andconvex deploy --cmdinjects the selected deployment URL into production and preview builds. Thestarter instead displayed manual setup instructions when the value was absent, and an
environment-free build could prerender that message as the home page.
The fix must preserve the existing rendering contract: exact
/and/aboutare static generatedpages, while
/index.htmlremains the route-neutral SPA fallback for other app routes.Change
/at/_landing.html,/aboutat/about/index.html, and the SPA shell at/index.html_redirectsblockCloudflare builds still receive the real URL from Convex
VITE_CONVEX_URLValidation
vp run checkVITE_CONVEX_URL=http://127.0.0.1:3210 vp run buildVITE_CONVEX_URL=http://127.0.0.1:3210 CLOUDFLARE_WORKER_NAME=samebase-app vp run deploy:dry-runVITE_CONVEX_URL=http://127.0.0.1:3210 CLOUDFLARE_WORKER_NAME=samebase-app vp run deploy:preview:dry-rundist/client/index.html,dist/client/_landing.html,dist/client/about/index.html, and the generated exact redirects