-
Notifications
You must be signed in to change notification settings - Fork 324
Store optimized assets for all photos #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Testing this out now 👍🏽 ✅ Building with all |
Thanks so much for checking @DevinTyler26! Will ship a tool next to upgrade your whole library, and then it would be great if you tested static generation of OG images again. In the meantime, can you confirm that adding/deleting photos works? And that you see a list of optimized files under "storage" when editing a newly created photo? |
@sambecker I am getting an error trying to upload a photo:
Trying to update a tag on an old photo also fails:
|
Thanks for checking @DevinTyler26! Just pushed a MinIO-specific update. Can you pull down the latest changes and try to:
And let me know if you get any errors or warnings? |
Amazing! Thank you so much for testing, and catching that bug. Will merge soon! |
This is cool. Something I wanted for a long time. |
Same! Excited for this to improve stability in some setups, with reasonable performance/usage characteristics. |
@DevinTyler26 @XahidEx @christojeffrey just flagged all older photo as unoptimized. Let me know if you run into any issues updating your libraries. @DevinTyler26 I'm especially curious to know if upgrading your library unlocks OG image static pre-rendering in your setup. ![]() |
I tried building twice with OG image static pre-rendering set and unfortunately with MinIO I am still getting build errors:
Build 2
I'll try with R2 soon and get back to you |
I am getting a new error trying to upload photos after yesterday's released that enabled photos to be optimized
It's odd, after trying to press |
Out of curiosity, does adding 1 work but not several? Once you click "Add" do you still see the original file in the /uploads tab? Would love to see what a screen grab video looks like when this works and doesn't work. One theory: if you get rate-limited when pre-rendering assets, I wonder if that also breaks file storage operations until the service cools down? |
Any chance these tips can prove/disprove whether or not Cloudflare is rate-limiting? The randomness of the crashes—and the fact that it doesn't seem to matter what the files are, or where they are—makes it seem like network layer problem |
@christojeffrey can you confirm photo uploads/deletions work with the latest on |
will do! |
Thank you @christojeffrey! |
It's working. |
Incredible report @christojeffrey thank you so much for doing all those checks ❤️
Can you post a link to this file? Wonder if files this big can be optimized on client before uploading 🤔 |
Glad to help!
Here's the link to the JPG file that I was using: https://www.examplefile.com/image/jpg/50-mb-jpg-sample-file |
photo-{storageId}-sm.jpg
photo-{storageId}-md.jpg
photo-{storageId}-lg.jpg
next/image
) urls when they exist for operations like og image generation and image manipulation