Skip to content

Conversation

@julian9499
Copy link
Contributor

@julian9499 julian9499 commented Nov 24, 2025

What does this PR do?

This PR aims to fix the bootstrap-salt.sh script for linux based operating systems that install the newest pip version. The removal of the option --global-option causes the script to fail. The removal is discussed in this PR:

As well as in the changelog of pip:pypa/pip#11859

What issues does this PR fix or reference?

pypa/pip#11859.

Previous Behavior

INFO -- saltstack-ubuntu: �[1;32m *  INFO�[0m: Installing Built Salt Wheel
INFO -- saltstack-ubuntu: 
INFO -- saltstack-ubuntu: Usage:   
INFO -- saltstack-ubuntu:   pip3.10 install [options] <requirement specifier> [package-index-options] ...
INFO -- saltstack-ubuntu:   pip3.10 install [options] -r <requirements file> [package-index-options] ...
INFO -- saltstack-ubuntu:   pip3.10 install [options] [-e] <vcs project url> ...
INFO -- saltstack-ubuntu:   pip3.10 install [options] [-e] <local project path> ...
INFO -- saltstack-ubuntu:   pip3.10 install [options] <archive url/path> ...
INFO -- saltstack-ubuntu: 
INFO -- saltstack-ubuntu: no such option: --global-option
INFO -- saltstack-ubuntu: �[1;31m * ERROR�[0m: Failed to run install_ubuntu_git()!!!

New Behavior

INFO -- saltstack-ubuntu: �[1;32m *  INFO�[0m: Running install_ubuntu_git()
INFO -- saltstack-ubuntu: �[1;32m *  INFO�[0m: Installing salt using python3, Python 3.10.12

As shown the new behaviour allows the script to continue and allowed my salt-kitchen stack to run again

@julian9499 julian9499 marked this pull request as ready for review November 24, 2025 12:13
@julian9499 julian9499 requested a review from twangboy November 25, 2025 08:28
@twangboy twangboy self-assigned this Nov 25, 2025
@twangboy twangboy merged commit 78ccd83 into saltstack:develop Nov 25, 2025
83 checks passed
@julian9499 julian9499 deleted the julian9499/replace-deprecated-pip-flag branch November 26, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants