feat: @W-18480458: Implementation of update references across Omnistudio components #353

sf-kishore-kurri · 2025-08-01T16:34:12Z

Changes:

Handling references updates post migration clean up changes
Added logic to perform migrate in correct order DM -> IP -> OS and FC
Created the namingRegistry to store old and cleanup name for lookup
Added the test cases

What does this PR do?

What issues does this PR fix or reference?

sf-aastha-paruthi · 2025-08-04T04:48:50Z

In case of OS and FC, both can have dependencies on each other. Is the correct order change mentioned taking care of that.

sf-kishore-kurri · 2025-08-04T04:51:21Z

e correct order change mentioned taking care

The order of migration happens like DM, IP, OS and FC so if OS has any FC dependency it will be taken care by the namingRegistry because it has the oldName <-> cleanedName so it will update automatically.

sf-aastha-paruthi · 2025-08-04T06:04:59Z

e correct order change mentioned taking care

The order of migration happens like DM, IP, OS and FC so if OS has any FC dependency it will be taken care by the namingRegistry because it has the oldName <-> cleanedName so it will update automatically.

This will not ensure the correct reference update. The unmigrated or Error items will not be handled correctly.

src/commands/omnistudio/migration/migrate.ts

sf-aastha-paruthi · 2025-08-04T05:39:16Z

src/migration/NameMappingRegistry.ts

+   */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  public preProcessComponents(
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any


Please try avoiding es lint checks

sf-aastha-paruthi · 2025-08-04T05:45:02Z

src/migration/flexcard.ts

+    if (type === Constants.DataRaptorComponentName || type === 'DataRaptor') {
+      // Handle DataRaptor using registry
+      const originalBundle = dataSource.value?.bundle || '';
+      if (originalBundle && this.nameRegistry.hasDataMapperMapping(originalBundle)) {


In what scenarios will the nameRegistry might not have the nameMapping.

In most cases, registry should have the key->value but added fallback so that any missing case also update will be done based on cleaned Name

sf-aastha-paruthi · 2025-08-04T05:45:27Z

src/migration/flexcard.ts

+      if (originalBundle && this.nameRegistry.hasDataMapperMapping(originalBundle)) {
+        dataSource.value.bundle = this.nameRegistry.getDataMapperCleanedName(originalBundle);
+      } else {
+        dataSource.value.bundle = this.cleanName(originalBundle);


Does the nameregistry need to be updated?

Ideally we shouldn't see any misses because registry is prepared based on pre-migrated data and else logic is fallback to avoid not clean up names

We should add some logs to let us know about any such miss

sure @snehaljha-sf

src/migration/NameMappingRegistry.ts

src/commands/omnistudio/migration/migrate.ts

sf-aastha-paruthi · 2025-08-04T06:11:06Z

src/commands/omnistudio/migration/migrate.ts

+  /**
+   * Get migration objects in the correct dependency order:
+   * 1. DataMappers (lowest dependencies)
+   * 2. OmniScripts/Integration Procedures


Update the comment to reflect the correct order.

sf-aastha-paruthi · 2025-08-04T06:12:06Z

src/commands/omnistudio/migration/migrate.ts

          break;
        case Constants.GlobalAutoNumber:
-          migrationObjects.push(new GlobalAutoNumberMigrationTool(namespace, conn, this.logger, messages, this.ux));
+          migrationObjects.push(
+            new GlobalAutoNumberMigrationTool(namespace, conn, this.logger, messages, this.ux, nameRegistry)


If this is independent item, do we still have dependency on nameRegistry.

For now, I'm passing the namingRegistry to GlobalAutoNumber migration process as well so that we can use it in future for any reference updates

sf-kishore-kurri · 2025-08-04T07:25:48Z

e correct reference update. T

The failure/ error ones should be remigrated then name registry will take care of it of update references

src/commands/omnistudio/migration/migrate.ts

snehaljha-sf · 2025-08-04T08:43:56Z

src/commands/omnistudio/migration/migrate.ts

+    nameRegistry.clear(); // Clear any previous mappings
+
+    Logger.log(messages.getMessage('startingComponentPreProcessing'));
+    await this.preProcessAllComponents(nameRegistry, namespace, conn, migrateOnly);


nameRegistry follows a singleton pattern, we don't need to add this dependency while calling a function

you mean NameMappingRegistry.getInstance() should be good instead of passing

src/migration/NameMappingRegistry.ts

sf-aastha-paruthi · 2025-08-04T09:20:02Z

src/commands/omnistudio/migration/migrate.ts

+        // Use ProjectPathUtil for APEX project folder selection (matches assess.ts logic)
+        projectPath = await ProjectPathUtil.getProjectPath(messages, true);
+        targetApexNamespace = await this.getTargetApexNamespace(objectsToProcess, targetApexNamespace);
+        await this.handleExperienceSitePrerequisites(


This has been moved to premigrate class.

yes, its merge conflict issue taking care of it

sf-kishore-kurri · 2025-08-06T11:17:02Z

@snehaljha-sf @sf-aastha-paruthi Please review the changes

src/commands/omnistudio/migration/migrate.ts

sf-aastha-paruthi · 2025-08-08T10:21:48Z

src/commands/omnistudio/migration/migrate.ts

+          isExperienceBundleMetadataAPIProgramaticallyEnabled
+        );
+        Logger.logVerbose(
+          'The objects to process after handleExpSitePrerequisite are ' + JSON.stringify(objectsToProcess)


This has been moved to message.json

Even on latest, we aren't using the messages

src/commands/omnistudio/migration/assess.ts

sf-aastha-paruthi · 2025-08-08T10:26:33Z

src/commands/omnistudio/migration/migrate.ts

    allVersions: any
  ): MigrationTool[] {
    if (!migrateOnly) {
+      // Correct order: DataMapper -> OmniScript/IP -> FlexCard -> GlobalAutoNumber


nit, remove duplicate comment, comment in line 383 already covers the ordering.

sf-aastha-paruthi · 2025-08-08T10:34:21Z

src/commands/omnistudio/migration/migrate.ts

+  /**
+   * Query FlexCards from the org
+   */
+  private async queryFlexCards(conn: any, namespace: string): Promise<any[]> {


All the 4 functions are making the same call to query and then return the resuts, just the query is different. The query can be separated and the other part can be put to a common function to avoid duplicacy.

sf-aastha-paruthi · 2025-08-08T10:38:00Z

src/migration/omniscript.ts

@@ -196,10 +200,11 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
    flexCardAssessmentInfos: FlexCardAssessmentInfo[]
  ): Promise<OmniAssessmentInfo> {
    try {
-      Logger.log(this.messages.getMessage('startingOmniScriptAssessment'));
+      const exportComponentType =
+        this.exportType === OmniScriptExportType.IP ? 'Integration Procedures' : 'Omniscripts';


getName() can be used.

src/migration/omniscript.ts

…dio components Changes: - Handling references udpates post migration clean up changes - Added logic to perform migrate in correct order DM -> IP -> OS and FC - Created the namingRegistry to store old and cleanup name for lookup - Added the test cases

Changes: - Handling of skipping Angular Omniscript dependencies FC and OS - Split the Omniscript and IP migration and also corrected the labels - Added labels and test cases

sf-kishore-kurri · 2025-08-09T08:23:44Z

@snehaljha-sf @sf-aastha-paruthi addressed the review comments

sf-kishore-kurri requested a review from a team as a code owner August 1, 2025 16:34

salesforce-cla bot added the cla:signed label Aug 1, 2025

sf-aastha-paruthi reviewed Aug 4, 2025

View reviewed changes

snehaljha-sf reviewed Aug 4, 2025

View reviewed changes

src/commands/omnistudio/migration/migrate.ts Show resolved Hide resolved

snehaljha-sf reviewed Aug 4, 2025

View reviewed changes

src/migration/NameMappingRegistry.ts Show resolved Hide resolved

sf-aastha-paruthi reviewed Aug 4, 2025

View reviewed changes

snehaljha-sf approved these changes Aug 8, 2025

View reviewed changes

sf-aastha-paruthi reviewed Aug 8, 2025

View reviewed changes

sf-aastha-paruthi approved these changes Aug 8, 2025

View reviewed changes

sf-kishore-kurri added 9 commits August 8, 2025 22:26

fix: @W-18480458: Code review comments and fixes

09974f4

fix: @W-18480458: Build failures

c0b56ff

fix: @W-18480458: Additional fixes

6b4f057

Changes: - Handling of skipping Angular Omniscript dependencies FC and OS - Split the Omniscript and IP migration and also corrected the labels - Added labels and test cases

fix: @W-18480458: Assessment issues

662f739

fix: @W-18480458 : Fix for label correction

7df4a40

fix: @W-18480458: OMA assess split for OS and IP

dadbc1e

fix: @W-18480458 : Resolved the conflicts and code review fixes

747cdb9

sf-kishore-kurri force-pushed the u/kkurri/W-18480458 branch from 34f3881 to 747cdb9 Compare August 8, 2025 18:20

fix: @W-18480458: more fixes

39ba058

snehaljha-sf merged commit a8affc3 into salesforcecli:prerelease/develop-ga Aug 11, 2025
1 check passed

feat: @W-18480458: Implementation of update references across Omnistudio components #353

feat: @W-18480458: Implementation of update references across Omnistudio components #353

Uh oh!

Conversation

sf-kishore-kurri commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

sf-aastha-paruthi commented Aug 4, 2025

Uh oh!

sf-kishore-kurri commented Aug 4, 2025

Uh oh!

sf-aastha-paruthi commented Aug 4, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sf-kishore-kurri commented Aug 4, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sf-kishore-kurri commented Aug 6, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sf-kishore-kurri commented Aug 9, 2025

Uh oh!

Uh oh!

Uh oh!

sf-kishore-kurri commented Aug 1, 2025 •

edited

Loading