Final async dbus bits on qml api #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JB#22724 Not spotting anything using voicecallhandler return values nor even the invokable methods. Thus just made the property write handlers behave async. Nothing was either using the error reporting path for initialization.
Been there since the initial commit but unlikely of any use, and can't find anything either. External usage for such an implementation detail would be strange to begin with. Let's just remove the property. The qml plugin itself still uses the c++ one from the other classes.
mlehtima
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got more or less done already earlier but then fell in the cracks: nemomobile/voicecall#59