Skip to content

Conversation

@Benjamin-eecs
Copy link
Collaborator

@Benjamin-eecs Benjamin-eecs marked this pull request as draft June 4, 2022 18:49
@mavenlin
Copy link
Member

Wondering whether there is a road blocker for this?

@Benjamin-eecs
Copy link
Collaborator Author

Wondering whether there is a road blocker for this?

Bazel dependency on OpenGL, also unittest

build --incompatible_strict_action_env --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --client_env=BAZEL_CXXOPTS=-std=c++17
build:debug --cxxopt=-DENVPOOL_TEST --compilation_mode=dbg -s
build:test --cxxopt=-DENVPOOL_TEST --copt=-g0 --copt=-O3 --copt=-DNDEBUG --copt=-msse --copt=-msse2 --copt=-mmmx
build:test --cxxopt=-DENVPOOL_TEST --copt=-g0 --copt=-O3 --copt=-DNDEBUG --copt=-msse --copt=-msse2 --copt=-mmmx --copt=-DMESA_EGL_NO_X11_HEADERS --copt=-DEGL_NO_X11 --copt=-DMJ_OSMESA
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// std::free(depth_array_);
mj_deleteData(data_);
mj_deleteModel(model_);
// mjr_freeContext(&context_);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed test is definitely caused by destructor.

]
)

# make test with GL loading error
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the python side also needs to load GL. Now it pops out ERROR: gladLoadGL error.

@Benjamin-eecs Benjamin-eecs added the help wanted Extra attention is needed label Oct 29, 2022
@Trinkle23897 Trinkle23897 linked an issue Jan 17, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] DeepMind Control Suite from pixels

2 participants