Skip to content

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Aug 21, 2025

Ref #8529

This gives me headaches. The core issue is there are no longer those flexible regex routes. Rather a more strict system, i.e. path-to-regexp updated. One place where I'm stuck is the proxy setup for projects. The idea I have is to create a small middleware, which checks if the supposed project ID is actually an UUID – otherwise to pass on internally to the next route. router level middleware This also implies that the "string-regex" passed to initUpgrade needs to be different than the more general path for the route.

What I got to work is e.g. the index page, loading frontend, redirecting to specific frontend pages, etc. The websocket connection doesn't work though. Some detail must be off.

Also, just while running the dev server, I get weird sudden crashes like that:

Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message:  should mgm exist
Location: crates/rspack_core/src/compiler/make/cutout/fix_issuers.rs:58

What I haven't even started to look into is the api/v2 endpoint:

 ✓ Compiled /api/v2 in 39s (10082 modules)
 ⨯ [TypeError: Cannot set property query of #<IncomingMessage> which has only a getter] {
  page: '/api/v2'
}

@haraldschilly haraldschilly changed the title npm: update express to 5.1 #8529 npm: update express to 5.1 Aug 21, 2025
@haraldschilly haraldschilly force-pushed the express-5-8529 branch 3 times, most recently from 6069139 to eddc6ad Compare August 22, 2025 08:17
@haraldschilly haraldschilly added PR-needs work E-hard needs-help I could really use help on this from somebody else! and removed PR-work in progress labels Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-hard needs-help I could really use help on this from somebody else! PR-needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant