Implement factorization for ideals of maximal number field orders - #42717
Open
cxzhong wants to merge 1 commit into
Open
Implement factorization for ideals of maximal number field orders#42717cxzhong wants to merge 1 commit into
cxzhong wants to merge 1 commit into
Conversation
|
Documentation preview for this PR (built with commit e79929e; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
factor()to number field order ideals when the order is maximal.The implementation reuses the existing fractional ideal factorization and changes the resulting factors back to the original order ideal monoid. This keeps every returned factor in the same maximal order as the input ideal. Factorization of non-maximal order ideals remains explicitly unsupported, and zero ideal factorization raises the standard arithmetic error.
The doctests cover reconstruction of the input ideal, factor parents, caching, the unit and zero ideals, non-maximal orders, ramified/inert/split primes in a quadratic field, and relative number fields. The number field order tutorial is updated for the explicit non-maximal-order error.
Fixes #42677.
📝 Checklist
⌛ Dependencies
None.