Skip to content

Implement factorization for ideals of maximal number field orders - #42717

Open
cxzhong wants to merge 1 commit into
sagemath:developfrom
cxzhong:codex/gh-42677-factor-maximal-order-ideals
Open

Implement factorization for ideals of maximal number field orders#42717
cxzhong wants to merge 1 commit into
sagemath:developfrom
cxzhong:codex/gh-42677-factor-maximal-order-ideals

Conversation

@cxzhong

@cxzhong cxzhong commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

This adds factor() to number field order ideals when the order is maximal.

The implementation reuses the existing fractional ideal factorization and changes the resulting factors back to the original order ideal monoid. This keeps every returned factor in the same maximal order as the input ideal. Factorization of non-maximal order ideals remains explicitly unsupported, and zero ideal factorization raises the standard arithmetic error.

The doctests cover reconstruction of the input ideal, factor parents, caching, the unit and zero ideals, non-maximal orders, ramified/inert/split primes in a quadratic field, and relative number fields. The number field order tutorial is updated for the explicit non-maximal-order error.

Fixes #42677.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the relevant documentation doctests.

⌛ Dependencies

None.

@github-actions

Copy link
Copy Markdown

Documentation preview for this PR (built with commit e79929e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ability to factor order ideals in number fields lost between Sage 10.4 and 10.9

1 participant