Fix coefficients with one-shot iterators - #42690
Open
OutisNemosseus wants to merge 2 commits into
Open
Conversation
|
Documentation preview for this PR (built with commit 7b1673b; changes) is ready! 🎉 |
OutisNemosseus
marked this pull request as ready for review
August 23, 2026 03:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ModularForm_abstract.coefficients()traversed its index iterable while computing missing coefficients and then traversed it again when constructing the return value. A one-shot iterator was therefore exhausted before the result was assembled, causing calls with generators to return an empty list.This change materializes non-integer iterables once before coefficient computation. It preserves the requested index order and duplicate indices.
A doctest using a genuine generator with indices
[3, 1, 3, 2]verifies the expected result[252, 1, 252, -24].Testing
git diff --checkThe full source-tree doctest runner was not available in the local conda Sage installation, so the focused Sage doctest was not collected locally.