Fix local_height_arch weighting real places as complex at prec=53 - #42678
Open
breatn wants to merge 1 commit into
Open
Fix local_height_arch weighting real places as complex at prec=53#42678breatn wants to merge 1 commit into
breatn wants to merge 1 commit into
Conversation
|
Documentation preview for this PR (built with commit b0aa81d; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local_height_archtested for a real place withisinstance(Kv, sage.rings.abc.RealField), butplaces(prec=53)maps intoRDF/CDF, andRDFis not asage.rings.abc.RealField; real places were therefore given the complex localdegree 2
global_height_archandglobal_heightwrong atprec=53:QuadraticField(2).gen().global_height(prec=53)returned0.693147180559945instead of0.346573590279973sage.rings.abc.RealDoubleFieldto the check, matching the idiom already used inNumberField_generic.hilbert_symbolFixes #31185.
📝 Checklist