some annotations for _gap_init_ -> str #41411
Open
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
positive review if tests pass. note: breaking the "not to be used directly" off is a visible (in documentation formatting) change. I'm neutral about this. [edit: hm, this isn't rendered to the HTML anyway.] |
|
Documentation preview for this PR (built with commit 5a21dca; changes) is ready! 🎉 |
Contributor
Author
|
thanks, I am setting to positive now |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 8, 2026
as this was missing in a few cases ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41411 Reported by: Frédéric Chapoton Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as this was missing in a few cases
📝 Checklist