Skip to content

Conversation

Eloitor
Copy link
Contributor

@Eloitor Eloitor commented Jun 5, 2025

This PR ensures that the local splitting is optimal with respect to the maximal order.

When computing a local splitting without magma, the splitting was not checked to be optimal. This produced a ValueError bug, when the image of some element of the basis of the maximal order had negative valuation.

Fixes #40209

For example:

sage: X = BruhatTitsQuotient(7, 5*17*13)
sage: X.genus_no_formula()
385
sage: X.genus()
385

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Jun 5, 2025

Documentation preview for this PR (built with commit 803c317; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@Eloitor
Copy link
Contributor Author

Eloitor commented Jun 5, 2025

ready for review

@Eloitor
Copy link
Contributor Author

Eloitor commented Jun 6, 2025

If I'm not wrong this could be simplified by #23486

@fchapoton
Copy link
Contributor

linter is not happy

@Eloitor
Copy link
Contributor Author

Eloitor commented Jun 6, 2025

I don't know how to fix it: src/sage/modular/btquotients/btquotient.py:2206:1: RST218 Literal block expected; none found.

@fchapoton
Copy link
Contributor

I have fixed it for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

btquotient ValueError: negative valuation
3 participants