Fix the atomicity of cy_atomic_int #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building sage,
meson.buildincorrectly sets allCYSIGNALS_*macros to 0 because of lacks ofmainfunction, which leads to a non-atomic declaration ofcy_atomic_int.Moreover, the
cy_atomic_inttypedefs instruct_signals.hwas structured in a way that when it is compiled by a C++ compiler in an environment with a C compiler that supports_Atomic, it would never usestd::atomic, which is incorrect and might cause compilation problem when the C++ compiler does not support_Atomic. This problem was hidden by the incorrect configuration ofmeson.buildabove but got surfaced after themeson.buildfix.As a context: LLewark/khoca#3